[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL359092: Kill modify-python-lldb.py (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D61000?vs

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

clayborg accepted this revision. clayborg added a comment. Thanks for the diff! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Since this just changes how we fix up comments for the generated functions in lldb.py, I can't see any harm in removing it. It is clearly showing you a C-view of the function, so char -> st

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath added a comment. Sure. This is the diff: F8747706: modify.diff . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

clayborg added a comment. Can you post a diff of things before and after? Hard to tell what we are opting out of just by seeing this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-co

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath created this revision. labath added reviewers: amccarth, jingham, clayborg. Herald added a subscriber: mgorny. After the last round of cleanups, this script was almost a no-op. The only piece of functionality that remained was the one which tried to make the swig-generated function signatur