This revision was automatically updated to reflect the committed changes.
Closed by commit rL358873: [NativePDB] Add anonymous namespaces support
(authored by aleksandr.urakov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:
aleksandr.urakov added a comment.
Thanks for the review! Sorry, I've forgot to include context in the updated
patch. Yes, it's exactly the case that is broken, I've left FIXME there until
it will be fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60817/new/
https://reviews.llvm.o
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Thanks for the changes. If the tests pass, then this LGTM. Just check the one
last question I added about the `AC1D` test.
(The diff in Phabricator looks very confused, as though you del
aleksandr.urakov marked an inline comment as done.
aleksandr.urakov added inline comments.
Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77
+// FIXME: Should be located in the namespace `A`, in the struct `C<1>`.
+A::C<1>::D AC1D;
+
amccarth wrote:
> Is this
aleksandr.urakov updated this revision to Diff 195863.
aleksandr.urakov added a comment.
Thank you for the comments, I agree with you. I've fixed the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60817/new/
https://reviews.llvm.org/D60817
Files:
lit/SymbolFile/NativePDB/Inputs
amccarth marked an inline comment as done.
amccarth added inline comments.
Comment at: source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:575
std::string ns = name_components.front()->toString();
-context = m_clang.GetUniqueNamespaceDeclaration(ns.c_str(), context);
+
amccarth added a comment.
Sorry for the slow response; I'm still learning about this code.
I like where this is going.
Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77
+// FIXME: Should be located in the namespace `A`, in the struct `C<1>`.
+A::C<1>::D AC1D;
+
---
labath added a reviewer: amccarth.
labath added a comment.
Don't know much about PDBs, but the change seems pretty straight-forward to me.
Zach would be the best person to review this, but he's probably busy with other
things now. Maybe Adrian could take a look?
Repository:
rLLDB LLDB
CHANG
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, aprantl.
This patch adds anonymous namespaces support to the native PDB plugin.
I had to
