[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

This revision was automatically updated to reflect the committed changes. Closed by commit rL357975: Breakpad: Parse Stack CFI records (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath updated this revision to Diff 194108. labath marked 2 inline comments as done. labath added a comment. Remove the fancy parsing of register expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 Files: source/Plugins/ObjectFile/Br

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath marked 5 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393 + llvm::StringRef LHS, RHS; + while (std::tie(Str, Line) = getToken(Line), !Str.empty()) { +if (Str.back() == ':') { // regN ---

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

amccarth added a comment. My concerns were address, so LGTM. I'll leave the rest to you and clayborg. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393 + llvm::StringRef LHS, RHS; + while (std::tie(Str, Line) = getToken(Line), !Str.empty()) { +if (Str.back() == ':') { // regN clayborg wrote: > Do we reall

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393 + llvm::StringRef LHS, RHS; + while (std::tie(Str, Line) = getToken(Line), !Str.empty()) { +if (Str.back() == ':') { // regN Do we really need to pull the

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath updated this revision to Diff 193849. labath added a comment. merge StackCFI and StackCFIInit records add some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 Files: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp source/

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath marked 3 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:173 + llvm::DenseMap UnwindRules; +}; + amccarth wrote: > I'm not a fan of deep class hierarchies, but given that StackCFIReco

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

amccarth added a comment. This looks good. I have a few questions inline, but none of those are major concerns. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:173 + llvm::DenseMap UnwindRules; +}; + I'm not a fan of deep class hierarchies,

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath created this revision. labath added reviewers: clayborg, amccarth, markmentovai. Herald added a subscriber: aprantl. This patch adds support for parsing STACK CFI records from breakpad files. For the expressions specifying the values of registers, only a basic parse is performed -- the reco