[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

2019-03-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357287: [CMake] Move link dependencies where they are used. (authored by JDevlieghere, committed by ). Changed prior t

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

2019-03-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I agree Utility is not the right place for this, but I am not sure about Core either. For curses, that's probably fine as an interim solution, because the usage is in IOHandler. However, for libedit, I'd expect this stuff to be in Host, since that's where we have the `

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

2019-03-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, labath, sgraenitz. Herald added a subscriber: mgorny. Herald added a project: LLDB. The utility library shouldn't depend on curses, libedit or python since it uses none of them. Move the first two to libC

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

2019-03-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 192745. JDevlieghere added a comment. And move python to the ScriptInterpreter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59970/new/ https://reviews.llvm.org/D59970 Files: lldb/source/Core/CMakeLists.txt lldb/source/Plugins/ScriptInterp