Re: [Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Jonas Devlieghere via lldb-commits
That being said, the tool won't generate register macros when the corresponding record macro is already in place, so the initial move would have to be done by hand. On Fri, Mar 15, 2019 at 1:47 PM Jonas Devlieghere wrote: > They actually are auto generated, using the lldb-inst tool. Currently th

Re: [Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Jonas Devlieghere via lldb-commits
They actually are auto generated, using the lldb-inst tool. Currently the record macros are inserted in place, while the register macros are dumped to stdout. I didn’t want to add too much complexity. However, it would be really easy to just dump the register macros in the file as well. On Fri, Ma

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Or better yet, make it a static method on each SB class. E.g. `SBTarget::InitializeReproducerRegistry();` etc, one for each class. Random thought, but this all seems like a very high maintenance strategy, having to manually update this registry when methods are added o

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. In D59427#1431383 , @krytarowski wrote: > It looks good to me, but maybe @JDevlieghere has a better idea how to > optimize it.

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. It looks good to me, but maybe @JDevlieghere has a better idea how to optimize it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 ___ lldb