[Lldb-commits] [PATCH] D59276: Delete dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356490: Delete dead code. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59276?vs=190350&id=191356#toc Repository: rLLDB LLD

[Lldb-commits] [PATCH] D59276: Delete dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given that this is not tested (I don't see any tests being removed) this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/ https://reviews.llvm.org/D59276

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/ https://reviews.llvm.org/D59276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner added a comment. In D59276#1426972 , @aprantl wrote: > One one hand this seems fine to remove, but on the other hand — won't these > functions come in handy to compare and debug differences between the LLDB and > LLVM DWARF parsers, while we are

[Lldb-commits] [PATCH] D59276: Delete dead code

aprantl added a comment. One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner created this revision. zturner added reviewers: clayborg, aprantl. Herald added subscribers: jdoerfert, mgorny. Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacinfoEntry) which are also unrefer