stella.stamenova added a comment.
This introduced a build break on Windows (which happened to coincide with
another build break).
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2317
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB355463: [ExpressionParser] Test GetClangResourceDir
(authored by xiaobai, committed by ).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D58748?vs=189392&id=189427#to
xiaobai updated this revision to Diff 189392.
xiaobai added a comment.
{Default,}ComputeClangDirectory -> {Default,}ComputeClangResourceDir
Added a comment explaining exactly how DefaultComputeClangResourceDir works
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://review
aprantl added a comment.
Looks mostly good!
Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:45
+static bool DefaultComputeClangDirectory(FileSpec &lldb_shlib_spec,
+ FileSpec &file_spec, bool verify) {
W
xiaobai added a comment.
@aprantl: Do you mind taking a look at this when you get a moment?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews.llvm.org/D58748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
labath added a reviewer: aprantl.
labath added a subscriber: aprantl.
labath added a comment.
Looks fine to me, but maybe @aprantl could give this a quick look, as he's the
one (IIRC) who introduced this function.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews
xiaobai updated this revision to Diff 188952.
xiaobai added a comment.
Minor changes to make MacOS work
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews.llvm.org/D58748
Files:
packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
source/Plugins/E
xiaobai planned changes to this revision.
xiaobai added a comment.
Looks like the test I wrote doesn't pass on MacOS, I need to investigate.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews.llvm.org/D58748
___
lldb-c
xiaobai updated this revision to Diff 188817.
xiaobai added a comment.
Reword comment to be clearer
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews.llvm.org/D58748
Files:
packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
source/Plugins/Expre
xiaobai updated this revision to Diff 188816.
xiaobai added a comment.
Address suggestions and add unit test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58748/new/
https://reviews.llvm.org/D58748
Files:
packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
source/Plug
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+# GetClangResourceDir doesn't work on windows yet
+@expectedFailureAll(oslist=["windows"])
@no_debug_info_test
xiaobai wrote:
> labath wro
xiaobai marked an inline comment as done.
xiaobai added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+# GetClangResourceDir doesn't work on windows yet
+@expectedFailureAll(oslist=["windows"])
@no_debug_info_test
-
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+# GetClangResourceDir doesn't work on windows yet
+@expectedFailureAll(oslist=["windows"])
@no_debug_info_test
xiaobai wrote:
> teemperor
xiaobai added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+# GetClangResourceDir doesn't work on windows yet
+@expectedFailureAll(oslist=["windows"])
@no_debug_info_test
teemperor wrote:
> Doesn't
teemperor added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+# GetClangResourceDir doesn't work on windows yet
+@expectedFailureAll(oslist=["windows"])
@no_debug_info_test
Doesn't that mean that w
xiaobai created this revision.
xiaobai added reviewers: zturner, clayborg.
Herald added subscribers: jdoerfert, kadircet, ioeric, ilya-biryukov.
Herald added a reviewer: serge-sans-paille.
I'm doing this because I plan on implementing `ComputeClangDirectory` on windows
so that `GetClangResourceDir
16 matches
Mail list logo
