This revision was automatically updated to reflect the committed changes.
Closed by commit rL247852: Add an OperatingSystem plugin to support goroutines
(authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D5871?vs=34914&id=34925#toc
Repository:
rL LLVM
http://reviews.llvm
clayborg accepted this revision.
clayborg added a comment.
Looks good then. I know there are things that are wrong with the current OS
plug-ins, so lets just work on improving them to be as useful as possible as I
am sure there will be things that need fixing.
Eventual goals could be to allow s
ribrdb marked 2 inline comments as done.
ribrdb added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ribrdb updated this revision to Diff 34914.
ribrdb added a comment.
> I am confused as to why we need to do this. If you have a memory thread, it
> might be backed by a real thread, or it might not. If it is backed by a
> real thread, we should be asking the real thread why it really stopp
brucem added a subscriber: brucem.
Comment at: test/lang/go/goroutines/TestGoroutines.py:14
@@ +13,3 @@
+@python_api_test
+@skipIfRemote # Not remote test suit ready
+@skipUnlessGoInstalled
Minor typo: should be "suite"
Repository:
rL LLVM
http://
clayborg added a comment.
Moving to SectionType is even more efficient than searching for symbols by
name, so please switch to that.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We have the notion of hard coded section types. See lldb::SectionType in
lldb-enumerations.h. You could always add your Go section to this section list
and then find the section
ribrdb updated this revision to Diff 34839.
ribrdb added a comment.
Fix cmake build.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
Files:
cmake/LLDBDependencies.cmake
include/lldb/Core/PluginManager.h
lib/Makefile
lldb.xcodeproj/project.pbxproj
source/Core/PluginManager.cpp
s
ribrdb updated this revision to Diff 34813.
ribrdb added a comment.
Ok, I've changed it to use the symbol table like the ASAN runtime does.
I'm not seeing any language info in the elf or macho file headers.
It looks like there's also a gosymtab section I could look for, but the name is
different
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision now requires changes to proceed.
If I understand this change correctly then OperatingSystemGo::CreateInstance
will be
ribrdb updated the summary for this revision.
ribrdb set the repository for this revision to rL LLVM.
ribrdb updated this revision to Diff 34806.
ribrdb added a comment.
I've updated this to load the plugin when modules are loaded, added a setting
to enable/disable the goroutine plugin, and added
11 matches
Mail list logo
