amccarth closed this revision.
amccarth added a comment.
Closed with r355121.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58648/new/
https://reviews.llvm.org/D58648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
amccarth added a comment.
Thanks. I really don't know what other types of conditions may trigger that
"request is not supported" message, so I'm going to shy away from trying to
make it more specific.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58648/new/
https://reviews.llvm.org/D
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me. If this "The request is not supported" error is something
that makes it's way to the user, and the error code is reasonably unambiguous
(it +/- only happens when debugging 64
amccarth updated this revision to Diff 188263.
amccarth added a comment.
Forgot to include context in original diff.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58648/new/
https://reviews.llvm.org/D58648
Files:
lldb/source/Host/windows/ProcessLauncherWindows.cpp
Index: lldb/sourc
amccarth created this revision.
amccarth added a reviewer: zturner.
The existing comment about over-allocating the command line was incorrect. The
contents of the command line may be changed, but it's not necessary to over
allocate. The changes will be limited to the existing contents of the s
