This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB354038: Don't source local .lldbinit in the test
suite (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58235?vs=186850&id=186865#toc
Repository:
rLLDB LL
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58235/new/
https://reviews.llvm.org/D58235
___
lldb-commits mailing list
lldb-commits
teemperor updated this revision to Diff 186850.
teemperor added a comment.
Ah yes, that also explains why the test suit failed. Fixed and the test now
passes, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58235/new/
https://reviews.llvm.org/D58235
Files:
lldb/lit/helper/tool
labath added a comment.
Are you sure you're adding this to the right place? This is modifying the
substitution for lldb-mi and not lldb..
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58235/new/
https://reviews.llvm.org/D58235
__
teemperor created this revision.
teemperor added a reviewer: labath.
Herald added subscribers: lldb-commits, abidh.
Herald added a reviewer: serge-sans-paille.
Herald added a project: LLDB.
As suggested by Pavel, we shouldn't let our tests parse the local .lldbinit to
prevent random test failures
