This revision was automatically updated to reflect the committed changes.
Closed by commit rL354047: [dotest] Fix compiler version number comparison
(authored by friss, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
friss updated this revision to Diff 186782.
friss added a comment.
Use LooseVersion as suggested by Zachary
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58219/new/
https://reviews.llvm.org/D58219
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/te
Try `import distutils.LooseVersion` and use that to do the comparison.
On Wed, Feb 13, 2019 at 4:49 PM Frederic Riss via Phabricator <
revi...@reviews.llvm.org> wrote:
> friss created this revision.
> friss added reviewers: zturner, labath.
> Herald added a reviewer: serge-sans-paille.
> Herald ad
friss created this revision.
friss added reviewers: zturner, labath.
Herald added a reviewer: serge-sans-paille.
Herald added a subscriber: jdoerfert.
dotest's version comparision function is just a lexicographical compare
of the version strings. This is obviously wrong. This patch implements
a nu
