This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB354104: Embed swig version into lldb.py in a different
way (authored by labath, committed by ).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D58172?vs=186676&id=186
labath added a comment.
Yes, my long term plan is to try to get rid of this file altogether. Doing the
hotpatching at runtime is an interesting idea. I may resort to that, but I
think it would be better to add all of these as regular blocks of inline
%pythoncode%, as that's how swig is meant to
zturner added a comment.
Long term, I wonder if we can just delete this entire `modify-python-lldb.py`
script. it seems like the entire purpose is to make sure that the SB methods
support iteration, equality, and some other basic stuff, and it does this by
inserting lines of python code into t
labath updated this revision to Diff 186676.
labath added a comment.
Include a basic test for this functionality I forgot to add
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58172/new/
https://reviews.llvm.org/D58172
Files:
packages/Python/lldbsuite/test/python_api/lldbutil/TestSwig
labath created this revision.
labath added reviewers: zturner, jingham.
Herald added a reviewer: serge-sans-paille.
Herald added a subscriber: jdoerfert.
Instead of doing string chopping on the resulting python file, get swig
to output the version for us. The two things which make slightly
non-tri
