[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

2019-02-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353906: [Reproducers] Integrate FileProvider with clang (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D58076?vs=186336&id=186573#toc Repository: rLLD

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

2019-02-12 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM with one comment. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:252-262 + + if (repro::Generator *g = repro::Reproducer::Instance().

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

2019-02-11 Thread Pavel Labath via Phabricator via lldb-commits
labath resigned from this revision. labath added a comment. Herald added a subscriber: jdoerfert. I don't know much about this part of the code, though the changes seem pretty straight-forward to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58076/new/ htt

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

2019-02-11 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, shafik, davide. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. This patch hooks up clang to LLDB's FileProvider, so that files used by clang are part of the reproducer. Repository: rLLDB LLDB