[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353709: [build.py] Add `-fms-compatibility-version=19` to `build.py` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Thank you! On Mon, Feb 11, 2019 at 6:01 PM Zachary Turner wrote: > Lgtm! > On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < > revi...@reviews.llvm.org> wrote: > >> aleksandr.urakov added a comment. >> >> Zachary, can you take a look? please? >> >> >> Repository: >> rLLDB LLD

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Lgtm! On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Zachary, can you take a look? please? > > > Repository: > rLLDB LLDB > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D57809/new/ > > https

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov added a comment. Zachary, can you take a look? please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57809/new/ https://reviews.llvm.org/D57809 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, but let's wait for zachary too. In D57809#1386883 , @aleksandr.urakov wrote: > I've checked your solution, and it's worked for

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov updated this revision to Diff 185526. aleksandr.urakov added a comment. I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I don't think this should be necessary. Based on my experiments, the fact whether clang-cl defines `char32_t` depends on the version of visual studio it is emulating (`-fms-compatibi

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: lldb-commits. On my system, `clang-cl` can't compile tests containing `char16_