[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL352899: [lldb] Relax libc++ ABI version checking (authored by thomasanderson, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57466?vs=184418&id=184798#t

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

labath accepted this revision. labath added a comment. Yes, I suppose it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. labath, was that an lg? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

labath added a comment. I was going to say that this has the potential of breaking libstdc++ formatters, but it looks like you found that out already. Since the libc++ inline namespace can really be anything, it makes sense to have the regex match that. Since libstdc++ (AFAIK) doesn't have that

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson added a comment. In D57466#1377696 , @davide wrote: > As long as this doesn't break macOS, it's fine. (just run the tests and watch > the bots). Latest revision fixes 2 test failures on Linux. The first was because ".+" was matching too

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson updated this revision to Diff 184418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 Files: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp Index: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp =

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. As long as this doesn't break macOS, it's fine. (just run the tests and watch the bots). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://re

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. aprantl might be a good reviewer for this. The motivation here is that we set `_LIBCPP_ABI_VERSION` for chromium, which then confuses lldb. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson created this revision. thomasanderson added reviewers: EricWF, thakis. Herald added subscribers: abidh, jfb. libc++ has programmable ABI versioning controllable with the _LIBCPP_ABI_VERSION macro. Currently there are at least 3 settings used in real systems (1 as the default, ndk1