asmith updated this revision to Diff 185817.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56231/new/
https://reviews.llvm.org/D56231
Files:
include/lldb/Host/File.h
include/lldb/Host/FileSystem.h
source/Host/common/File.cpp
source/Host/common/FileSystem.cpp
source/Plugins/Proc
asmith added a comment.
Any other comments on this one?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56231/new/
https://reviews.llvm.org/D56231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
asmith updated this revision to Diff 180992.
asmith added a comment.
Added lock suggested in review
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56231/new/
https://reviews.llvm.org/D56231
Files:
include/lldb/Host/File.h
include/lldb/Host/FileSystem.h
source/Host/common/File.cpp
zturner added inline comments.
Comment at: source/Host/common/File.cpp:606-607
#else
long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
+SeekFromStart(offset);
error = Write(buf, num_bytes);
Be careful here. `pwrite` on posix is atomic, which means th
Hui added a comment.
With all the aaron's pending reviews on lldb-server, I could try the patch with
the following platform apis.
Seems to me is working on Windows and no regression on Linux side. Some
difference (performance) might be
(1) Previous, the vfile:write packet has a maximum as 102
labath added a reviewer: labath.
labath added a comment.
Nice to see some action on the lldb-server for windows front. It looks like it
should be easy to add a unit test for the File::Write bug you fixed. Can you
add something like that?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
ht
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added subscribers: lldb-commits, abidh.
This commit contains the following changes:
- Rewrite vfile close/read/write packet handlers with portable routines from
lldb. This removes #if(s) and allows the handlers t
