labath marked an inline comment as done.
labath added inline comments.
Comment at: lldb/trunk/source/Target/ProcessLaunchInfo.cpp:220
+ if (!m_pty->OpenFirstAvailableMaster(open_flags, nullptr, 0)) {
+return llvm::createStringError(llvm::inconvertibleErrorCode(),
+
Hui added inline comments.
Comment at: lldb/trunk/source/Target/ProcessLaunchInfo.cpp:220
+ if (!m_pty->OpenFirstAvailableMaster(open_flags, nullptr, 0)) {
+return llvm::createStringError(llvm::inconvertibleErrorCode(),
+ "PTY::OpenFirstAvai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350617: ProcessLaunchInfo: Remove Target reference (authored
by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
labath created this revision.
labath added reviewers: zturner, jingham, teemperor.
The target was being used in FinalizeFileActions to provide default
values for stdin/out/err. Also, most of the logic of this function was
very specific to how the lldb's Target class wants to launch processes,
so I
