[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar abandoned this revision. grimar added a comment. Yep, MSVS2017 works fine here for me too. Thanks, Pavel! I am abandoning it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits m

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar planned changes to this revision. grimar added a comment. I'll try to switch to MSVS 2017 and recheck this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. In D55995#1352772 , @labath wrote: > BTW, I've been compiling lldb with VS2017 and haven't run into this issue. > Also, with the imminent release of VS2019, I expect someone will soon start a > thread proposing to drop VS2015, so

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

labath added a reviewer: zturner. labath added a comment. BTW, I've been compiling lldb with VS2017 and haven't run into this issue. Also, with the imminent release of VS2019, I expect someone will soon start a thread proposing to drop VS2015, so you might be better of switching to a newer comp

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar updated this revision to Diff 179535. grimar edited the summary of this revision. grimar added a comment. - Addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 Files: include/lldb/lldb-defines.h source/Commands/C

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. In D55995#1339099 , @clayborg wrote: > The changes from "constexpr" to "const" might introduce global constructors > in the shared library which is what we were trying to avoid. The less work > that the LLDB shared library does on

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The changes from "constexpr" to "const" might introduce global constructors in the shared library which is what we were trying to avoid. The less work that the LLDB shared librar

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar created this revision. grimar added reviewers: clayborg, LLDB. Currently, lldb fails to build with the following errors when MSVS update 3 is used: > fatal error C1001: An internal error has occurred in the compiler. > (compiler file 'msc1.cpp', line 1468) > To work around this problem,