This revision was automatically updated to reflect the committed changes.
Closed by commit rL349818: [dotest] Consider unexpected passes as failures.
(authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55835?vs=1
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good to me. Modifying this code is not ideal, but this is a pretty small
but fundamental change in how unittest works. Changing the treatment of
unexpected successes anywhere else would
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, davide, jingham, clayborg.
JDevlieghere added a project: LLDB.
Unexpected successes should be considered failures because they can hide
regressions when not addressed. When a test is fixed and not re-enabled, it can
easily
