[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

jankratochvil added a comment. There is also failing `TestImagineList` on my Fedora buildbot : ++ : 'RUN: at line 19' ++ cat /home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Funct

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rL355570: [Reproducers] Add tests for different types of functionality (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/Reproducer/Functionalities/TestDataFormatter.test:6 +# RUN: rm -rf %t.repro +# RUN: %clang -x c++ %S/Inputs/foo.cpp -g -o %t.out +

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lit/Reproducer/Functionalities/TestImagineList.test:17 + +# RUN: rm -rf + aprantl wrote: > really? ;-) 🤔🤔🤔 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere updated this revision to Diff 189610. JDevlieghere added a comment. Remove spurious RUN command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.org/D55626 Files: lldb/lit/Reproducer/Functionalities/Inputs/DataFormatter.in lldb/lit/Reprodu

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lldb/lit/Reproducer/Functionalities/TestImagineList.test:8 + +# RUN: rm -rf %T/imagelist +# RUN: rm -rf %t.txt There's still a %T CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere updated this revision to Diff 189608. JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Feedback Adrian CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.org/D55626 Files: lldb/lit/Reproducer/Functionalities/Inputs/D

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl requested changes to this revision. aprantl added inline comments. This revision now requires changes to proceed. Herald added a subscriber: jdoerfert. Comment at: lit/Reproducer/Functionalities/Inputs/foo.cpp:3 +public: + Foo(int i, double d) : m_i(i), m_d(d){}; + -

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/TestDataFormatter.test:5 + +# RUN: rm -rf %T/dataformatter +# RUN: %clang -x c++ %S/Inputs/foo.cpp -g -o %t.out same here Comment at: lit/Reproducer/Functionalities/TestS

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lit/Reproducer/Functionalities/Inputs/stepping.c:8 +// +//===--===// +#include aprantl wrote: > Why

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere updated this revision to Diff 178075. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address Adrian's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.org/D55626 Files: lit/Reproducer/Functionalities/Inp

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/TestStepping.test:39 +# CHECK: 1 breakpoints disabled. +# CHECK: 1 breakpoints disabled. + aprantl wrote: > perhaps copy the commands in here so it is easier to understand what is being >

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/Inputs/stepping.c:8 +// +//===--===// +#include Why does only this file have a header? Comment at: li

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, aprantl, zturner. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. This patch adds test that check that functionality in lldb continues to work when replaying a reproducer. Currently the pa