[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this in favor of D56322 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55582/new/ https://reviews.llvm.org/D55582 ___ lldb-commi

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. In D55582#1331333 , @JDevlieghere wrote: > Yes, this is how SB record/replay will work. I don't disagree with this > approach, it's just that, as I said in my earlier reply, I was hoping to get > the driver working without the ne

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere added a comment. In D55582#1331145 , @labath wrote: > Hm.. so the way, I'd imagine this working is that `-o` and friends (as well > as pretty much every other command line argument) would be captured by the SB > recorder, once they cross the

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. In D55582#1330715 , @JDevlieghere wrote: > I played around with this today: > > - I'm totally convinced that we should replay by swapping out stdin with a > file from the reproducer. This makes this better overall. > - I'm not con

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere added a comment. I played around with this today: - I'm totally convinced that we should replay by swapping out stdin with a file from the reproducer. This makes this better overall. - I'm not convinced that capturing just stdin is an improvement. What I like about the current appr

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere added a comment. In D55582#1329479 , @labath wrote: > I am very sorry about this, but I am having some second thoughts about the > `RunReplay` thingy. I don't think I've correctly expressed what is bothering > me about it (and that's probabl

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. I am very sorry about this, but I am having some second thoughts about the `RunReplay` thingy. I don't think I've correctly expressed what is bothering me about it (and that's probably because I wasn't clear with myself about what is bothering me). I'll try to formulate

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere updated this revision to Diff 177950. JDevlieghere added a comment. When sourcing a file we should also ignore the individual commands otherwise they end up getting executed twice, once as part of the `command source` and once for every individual command in the file. CHANGES SINC

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere updated this revision to Diff 177906. JDevlieghere added a comment. Skip driver logic when replaying, otherwise commands are executed or sourced twice, once in the driver and once by replaying the commands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55582/new/ https://r

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere updated this revision to Diff 177878. JDevlieghere added a comment. Address Pavel's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55582/new/ https://reviews.llvm.org/D55582 Files: include/lldb/Core/Debugger.h include/lldb/Interpreter/CommandInterpreter.h li

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. My main question is why do we need the separate `SBDebugger::RunReplay` API for this. Shouldn't the record/replay be as transparent as possible? I would expect that `SBDebugger::RunCommandInterpreter` will detect that it is running in replay mode and use the recorded inp

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, sgraenitz. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. Add support for reproducing to the command interpreter. In capture mode we capture all the command to file and in reproducer mode