Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Stella Stamenova via lldb-commits
Ah, yes, it does. It looks like it does contain /usr/bin. Script Arguments: Arch: 64 Compiler: any Outdir: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output Output: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output/exec-next-instruction.test.

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Zachary Turner via lldb-commits
Don't we print the environment in verbose mode? Can we see that output as well? On Fri, Dec 14, 2018 at 11:53 AM Stella Stamenova wrote: > The verbose output is below. If I run the two commands on the command > line, they both succeed, but when I run them through build.py, the link > command is

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Stella Stamenova via lldb-commits
The verbose output is below. If I run the two commands on the command line, they both succeed, but when I run them through build.py, the link command is failing. I suspect that the process that gets created through python doesn't inherit the environment with the PATH set, so it can't find the li

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Pavel Labath via lldb-commits
On 14/12/2018 20:32, Stella Stamenova via Phabricator wrote: stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: Interesting. Can yo

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: 2018-12-14T19:24:41.8890855Z 2018-12-14T19:24:41.8904193Z

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-12 Thread Zachary Turner via lldb-commits
It's fine, I was mostly just curious. On Wed, Dec 12, 2018 at 8:52 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath marked an inline comment as done. > labath added inline comments. > > > > Comment at: lldb/trunk/lit/helper/build.py:630 > +a

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-12 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added inline comments. Comment at: lldb/trunk/lit/helper/build.py:630 +args.append('-nostdinc') +args.append('-static') +args.append('-c') zturner wrote: > Why do we need this? Withou

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-12 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: lldb/trunk/lit/helper/build.py:630 +args.append('-nostdinc') +args.append('-static') +args.append('-c') Why do we need this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-12 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL348918: build.py: Implement "gcc" builder (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-12 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 3 inline comments as done. labath added inline comments. Comment at: lit/BuildScript/toolchain-clang.test:1 +RUN: %build -n --verbose --arch=32 --compiler=clang --mode=compile-and-link -o %t/foo.exe foobar.c \ +RUN:| FileCheck --check-prefix=CHECK --check-prefi

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-11 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. A couple of small comments, but it looks good otherwise. Thanks! Comment at: lit/BuildScript/toolchain-clang.test:1 +RUN: %build -n --verbose --arch=32 --

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-07 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added a reviewer: zturner. Herald added subscribers: dexonsmith, mehdi_amini. This implements the gcc builder in build.py script to allow it to compile host executables when running on a non-windows host. Where it made sense, I tried to share code with the msvc