[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

2018-11-28 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 175730. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake + polishing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55012/new/ https://reviews.llvm.org/D55012 Files: CMakeLists.txt cmake/modules/LLDBConfig.cmake tools/d

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

2018-11-28 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 175729. sgraenitz added a comment. The default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55012

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

2018-11-28 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 175725. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary di

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

2018-11-28 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. Herald added subscribers: llvm-commits, mgorny. The first patch had to be reverted as I missed a few details. This review continues from https://reviews.llvm.org/D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with