This revision was automatically updated to reflect the committed changes.
Closed by commit rL347213: Don't use -O in lit tests. (authored by
zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54680?vs=174549&id=174609#toc
Reposi
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I don't have any other great ideas either and I'd say the proposed alternative
is not worth the complexity.
https://reviews.llvm.org/D54680
___
friss added a comment.
I do agree it's slightly easier to read this way. I was conflicted while
writing the tests between readability and conciseness. I think this is a good
compromise.
I do prefer to have the check lines with the commands rather than with the
source code though. The output is
zturner added a comment.
In https://reviews.llvm.org/D54680#1302408, @davide wrote:
> Is there a way of fixing this that doesn't require scattering the test
> between two files?
Unless we create a utility that extracts lines based on prefixes and outputs
them to a temporary file, I don't have
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Is there a way of fixing this that doesn't require scattering the test between
two files?
https://reviews.llvm.org/D54680
___
lldb-com
zturner created this revision.
zturner added a reviewer: friss.
Because of different shell quoting rules, and the fact that LLDB commands often
contain spaces, -O is not portable for writing command lines. Instead, we
should use explicit lldbinit files.
https://reviews.llvm.org/D54680
Files:
