aprantl closed this revision.
aprantl added a comment.
Looks like this landed in r345274 and wasn't properly closed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53677/new/
https://reviews.llvm.org/D53677
___
lldb-commits mailing list
lldb
labath accepted this revision.
labath added a comment.
lgtm. Sorry about the trouble.
https://reviews.llvm.org/D53677
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shafik added inline comments.
Comment at: source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1405
-llvm::StringRef version_part;
-
-if (sdk_name.startswith(sdk_strings[(int)desired_type])) {
- version_part =
- sdk_name.drop_front(strlen(sdk_strings[(int)des
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D53677
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
aprantl created this revision.
aprantl added reviewers: jingham, clayborg, labath.
This fixes a bug PlatformDarwin::SDKSupportsModule introduced by
https://reviews.llvm.org/D47889.
VersionTuple::tryParse() can deal with an optional third (micro) component, but
the parse will fail when there are
