This revision was automatically updated to reflect the committed changes.
Closed by commit rL345013: [PDB] Improve performance of the PDB DIA plugin
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53375?v
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53375#1271336, @Hui wrote:
> I think parsing types e.g. SymbolFilePDB::ParseTypes also has speed bumps.
> Will be good to have them cached too.
We are already caching them, see `m_types` field.
Repository:
rLLDB LLDB
https://r
Hui added a comment.
In https://reviews.llvm.org/D53375#1269504, @asmith wrote:
> Thanks for adding the cache. We noticed the slowdown also and were discussing
> the same thing. This LGTM if the other reviewers done have any comments.
I think parsing types e.g. SymbolFilePDB::ParseTypes also h
aleksandr.urakov added a comment.
Thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.
Thanks for adding the cache. We noticed the slowdown also and were discussing
the same thing. This LGTM if the other reviewers done have any comments.
Repository:
rLLDB LLDB
https://review
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch improves performance of `SymbolFilePDB` on huge executables in two
ways:
- cache names of public symbols
