[Lldb-commits] [PATCH] D52651: Add functionality to export settings

This revision was automatically updated to reflect the committed changes. Closed by commit rL345346: Add functionality to export settings (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52651?vs=170258&id=171

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB345346: Add functionality to export settings (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D52651?vs=170258&id=171231#toc Repository: rLLDB LLDB htt

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere added a comment. Thanks Raphael! With r345207 the empty behavior only works if you explicitly specify `-force`. I'll address the second issue before landing this. https://reviews.llvm.org/D52651 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Woops, I wanted to accept in my previous comment. https://reviews.llvm.org/D52651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry, this somehow didn't show up in my review queue. I think this can land after two minor things are fixed: - I think unknown arguments to write/read shouldn't be silently i

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere added a comment. @teemperor Can you have another look? https://reviews.llvm.org/D52651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere updated this revision to Diff 170258. JDevlieghere added a comment. - Back to the right diff. - Use `-f` as per the other patch. https://reviews.llvm.org/D52651 Files: include/lldb/Interpreter/OptionValue.h lit/Settings/TestExport.test source/Commands/CommandObjectSettings.cp

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere updated this revision to Diff 170252. JDevlieghere added a comment. Only clear setting when the force flag is set (as suggested offline by @jingham). https://reviews.llvm.org/D52651 Files: lit/Settings/TestSettingsSet.test source/Commands/CommandObjectSettings.cpp Index: sou

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere updated this revision to Diff 167892. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Split off `settings set` change into separate review: https://reviews.llvm.org/D52772 https://reviews.llvm.org/D52651 Files: include/lldb/Interpreter/OptionValue.h

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere updated this revision to Diff 167889. JDevlieghere added a comment. Thanks a lot for the feedback! I clearly overlooked some stuff when inspiring myself on the other CommandObject code. I've updated the diff: - Rename functionality to read and write for consistency with breakpoints

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

jingham added a comment. To Raphael's points: Argument completion handlers are set by the command object implementing HandleArgumentCompletion and dispatching to the CommandCompletions::eDiskFileCompletion. An example of this is in CommandObjectProcessLaunch. Note, arguments currently have a

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor added a comment. - Running `settings export /home/teemperor/foobar1 /home/teemperor/foobar2` will actually just create foobar1, but will not report any error that foobar2 is silently ignored. - Do we actually have a way to have file completion for the argument? (This doesn't have to

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Runnings `settings export` crashes LLDB: (lldb) down ❲ 8❳ CommandObjectSettingsExport::DoExecute(this=0x55652a80, args=0x7fffd6b8, result=0x7fffdd80

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere updated this revision to Diff 167722. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Rebase https://reviews.llvm.org/D52651 Files: include/lldb/Interpreter/OptionValue.h lit/Settings/TestExport.test source/Commands/CommandObjectSettings.cpp

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, teemperor. JDevlieghere added a project: LLDB. For the reproducer feature I need to be able to export and import the current LLDB configuration. To realize this I've extended the existing functionality to print