This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343348: Clean-up usage of OptionDefinition arrays
(authored by tkrasnukha, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52604?vs=167475&id=167515#toc
Repository:
rLLDB LLDB
tatyana-krasnukha added inline comments.
Comment at: tools/driver/Driver.cpp:581-585
+ if (g_num_options == 0) {
if (argc > 1)
error.SetErrorStringWithFormat("invalid number of options");
return error;
}
clayborg wrote:
> Do we even need this
tatyana-krasnukha updated this revision to Diff 167475.
tatyana-krasnukha added a comment.
Modifies Driver::ParseArgs checks
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52604
Files:
include/lldb/Target/Platform.h
source/Commands/CommandObjectDisassemble.h
source/Commands/CommandOb
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/driver/Driver.cpp:71
typedef struct {
uint32_t usage_mask; // Used to mark options that can be used together. If
(1
tatyana
tatyana-krasnukha added inline comments.
Comment at: tools/driver/Driver.cpp:71
typedef struct {
uint32_t usage_mask; // Used to mark options that can be used together. If
(1
This type is duplicated here to not break the encapsulation of lldb's private
t
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: clayborg, zturner.
tatyana-krasnukha added a project: LLDB.
Herald added a subscriber: lldb-commits.
Removed unused static arrays from headers, removed sentinel entry from
OptionDefinition array in Driver.cpp.
Repositor
