[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

2018-09-27 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52561 Files: source/Plugins/ExpressionParser/Clan

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

2018-09-27 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. looks fine, thanks :) Repository: rLLDB LLDB https://reviews.llvm.org/D52561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

2018-09-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: xbolva00. Herald added a subscriber: lldb-commits. The `ClangUserExpression::GetLanguageForExpr` method is currently a big source of sadness, as it's name implies that it's an accessor method, but it actually is also initializing some v