This revision was automatically updated to reflect the committed changes.
Closed by commit rL341506: Print column info in backtraces et al. if available
(authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51661?vs=1641
aprantl updated this revision to Diff 164104.
aprantl added a comment.
Address review feedback.
Thanks you, I was wondering how to properly implement an optional element!
https://reviews.llvm.org/D51661
Files:
include/lldb/Core/FormatEntity.h
packages/Python/lldbsuite/test/functionalities/
clayborg added inline comments.
Comment at: source/Core/FormatEntity.cpp:1826
+}
+// Column info is optional, so this always succeeds.
+return true;
Remove this comment
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51661
___
clayborg added a comment.
See my inlined comments about returning true and false correctly for the column
and the correction to the format string
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ a
aprantl added inline comments.
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ at ${line.file.basename}:${line.number}${line.column}}"
#define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
--
clayborg added a comment.
We shouldn't have the colon character be part of the ${line.column} formatting
itself. See inlined comments.
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ at ${line.fi
aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a subscriber: kubamracek.
This patch allows LLDB to print column info in backtraces et al. if available,
which is useful when the backtrace contains a frame like the following:
`f(can_crash(0), can_crash(
