[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added a comment. In https://reviews.llvm.org/D51604#1223455, @clayborg wrote: > In https://reviews.llvm.org/D51604#1223451, @xbolva00 wrote: > > > Thanks for review, commited as https://reviews.llvm.org/rL341387 > > > If you include the text: > > Differential Revision: https://reviews.

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

clayborg added a comment. In https://reviews.llvm.org/D51604#1223451, @xbolva00 wrote: > Thanks for review, commited as https://reviews.llvm.org/rL341387 If you include the text: Differential Revision: https://reviews.llvm.org/D51604 It will automatically close this and put in a comment wit

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added a comment. Thanks for review, commited as https://reviews.llvm.org/rL341387 https://reviews.llvm.org/D51604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D51604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 updated this revision to Diff 163852. xbolva00 added a comment. - Use abort https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp === --- source/Utility/LLDBAssert.cp

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

clayborg added a comment. Yes abort is better as exit will cause the global C++ destructor chain to be called. I was always thinking lldbassert() was aborting, but seeing as this is not the case this could cause problems if you enable it as it will be a change. Watch the buildbots carefully.

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

lemo added inline comments. Comment at: source/Utility/LLDBAssert.cpp:31 +"log, and as many details as possible\n"; + exit(1); } abort() may be a better choice here (exit() path calls a lot of shutdown code and it's not safe in a number of cases)

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 updated this revision to Diff 163818. xbolva00 added a comment. - Use early return https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp === --- source/Utility/LLDBAs

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added inline comments. Comment at: source/Utility/LLDBAssert.cpp:23 if (expression) ; else { JDevlieghere wrote: > I guess while we're at it we can turn this into an early return and use > LLVM_LIKELY? > > ``` > if (LLVM_LIKELY(expression))

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere added inline comments. Comment at: source/Utility/LLDBAssert.cpp:23 if (expression) ; else { I guess while we're at it we can turn this into an early return and use LLVM_LIKELY? ``` if (LLVM_LIKELY(expression)) return; ``` Reposito

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 created this revision. xbolva00 added reviewers: JDevlieghere, teemperor. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp =