shafik updated this revision to Diff 166144.
shafik added a comment.
Updating LibcxxVariantGetIndexValidity() to no longer do type check of __index.
It was left over from the old method of checking for an empty variant and was
also breaking clang 5.
https://reviews.llvm.org/D51520
Files:
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342421: [DataFormatters] Add formatter for C++17
std::variant (authored by shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51520?vs=16
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM now, thanks for the patch!
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
shafik updated this revision to Diff 165540.
shafik added a comment.
Applying clang-format to files I missed earlier
https://reviews.llvm.org/D51520
Files:
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefil
shafik added a comment.
@teemperor Thanks for the catch!
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
LibCxx.h/.cpp are still not clang-formatted. I ran clang-format over the patch
and pushed it here that this patch doesn't get stuck on this minor detail:
https://github.com/Tee
shafik updated this revision to Diff 165536.
shafik added a comment.
Applying clang-format
https://reviews.llvm.org/D51520
Files:
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
packages/Python/lldbs
shafik added a comment.
@vsk Interesting I ran git clang-format before generating the diff and it made
changes, so I am not sure what happened
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
vsk added a comment.
Please clang-format your diffs.
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes, that's a good way to do it.
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
shafik added a comment.
@vsk @jingham I believe I have addressed your comments, please review again.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:29
+std::variant v3;
+std::variant v_no_value;
+
--
shafik updated this revision to Diff 165201.
shafik marked 9 inline comments as done.
shafik added a comment.
Address comments on std::variant formatter
- Adding tests for reference to variant and variant of variant
- Refactoring test to be more efficient
- Refactoring unsafe code that assumed si
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
A bunch of little comments and two more substantial bits.
1. Can you add a test where we do "frame variable" on a one of these variants
when it has one value, and then continue to
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py:70
+self.expect("frame variable v_no_value",
+substrs=['v_no_value = No Value'])
shafik created this revision.
shafik added reviewers: jingham, davide.
Herald added subscribers: christof, mgorny.
Herald added a reviewer: EricWF.
Adding data formatter for libc++ std::variant and appropriate tests
https://reviews.llvm.org/D51520
Files:
lldb.xcodeproj/project.pbxproj
pack
15 matches
Mail list logo
