davide added a comment.
LGTM
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51374
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340885: [LLDB] Fix script to work with GNU sed (authored
by smeenai, committed by ).
Herald added a subscriber: abidh.
Changed prior to commit:
https://reviews.llvm.org/D51374?vs=162928&id=162988#toc
xiaobai accepted this revision.
xiaobai added a comment.
Regardless of compatibility, the man page for sed on OSX recommends not having
a zero length extension while editing the file in place. LGTM.
https://reviews.llvm.org/D51374
___
lldb-commits
smeenai created this revision.
smeenai added reviewers: beanz, davide, xiaobai.
GNU sed and BSD sed have a different command-line syntax for in-place
editing, and the current form of the script would only work with BSD
sed. The easiest way to get cross-platform behavior is to specify a
backup suff
