This revision was automatically updated to reflect the committed changes.
Closed by commit rL339611: Added test for Core/Range class. (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50620?vs=160439&id=160441#toc
teemperor updated this revision to Diff 160439.
teemperor added a comment.
- Addressed Vedant's comments (thanks!)
https://reviews.llvm.org/D50620
Files:
unittests/Core/CMakeLists.txt
unittests/Core/RangeTest.cpp
Index: unittests/Core/RangeTest.cpp
=
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, looks good with nitpicks.
Comment at: unittests/Core/RangeTest.cpp:139
+ RangeT r;
+ // FIXME: This is probably not intended.
+ EXPECT_TRUE(r.ContainsEndInclusive(0));
-
teemperor updated this revision to Diff 160286.
teemperor added a comment.
- Fixed typo in CMakeLists
https://reviews.llvm.org/D50620
Files:
unittests/Core/CMakeLists.txt
unittests/Core/RangeTest.cpp
Index: unittests/Core/RangeTest.cpp
==
teemperor added a comment.
(Also we maybe might want to merge the functionalities of Range and VMRange in
the future).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
teemperor created this revision.
teemperor added a reviewer: vsk.
Herald added a subscriber: mgorny.
We can optimize and refactor some of the classes in RangeMap.h, but first
we should have some tests for all the data structures in there. This adds a
first
batch of tests for the Range class itsel
