[Lldb-commits] [PATCH] D50334: Add ConstString test FromMidOfBufferStringRef

2018-08-08 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339292: Add ConstString test FromMidOfBufferStringRef (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50334?vs=159298&id=159806#toc Repository: rLL

[Lldb-commits] [PATCH] D50334: Add ConstString test FromMidOfBufferStringRef

2018-08-06 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In general, I would assume that a function taking a StringRef can take *any* StringRef object (including the non-terminated ones), unless the limitations are very clearly documented. That sai

[Lldb-commits] [PATCH] D50334: Add ConstString test FromMidOfBufferStringRef

2018-08-06 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added a reviewer: labath. It was not immediately clear to me whether or not non-null-terminated StringRef's are supported in ConstString and/or the counterpart mechanism. From this test it seems to be fine. Maybe useful to keep? https://reviews.llvm.o