[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338949: Fix a bug in VMRange (authored by lemo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

Looks like i was wrong, nevermind! On Fri, Aug 3, 2018 at 6:23 PM Leonard Mosescu via Phabricator via lldb-commits wrote: > lemo added subscribers: bgianfo, labath, penryu, teemperor, zturner. > lemo added a comment. > > Thanks Zach. I can't find llvm::contains() though, any pointers to it? > > >

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

zturner added a comment. Looks like i was wrong, nevermind! Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

lemo added subscribers: bgianfo, labath, penryu, teemperor, zturner. lemo added a comment. Thanks Zach. I can't find llvm::contains() though, any pointers to it? Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

Thanks Zach. I can't find llvm::contains() though, any pointers to it? On Fri, Aug 3, 2018 at 5:58 PM, Zachary Turner via Phabricator via lldb-commits wrote: > zturner added a subscriber: lemo. > zturner added a comment. > > I think we have llvm::contains() which would allow you to make this > s

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

zturner added a subscriber: lemo. zturner added a comment. I think we have llvm::contains() which would allow you to make this slightly better. Other than that, good find! Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

I think we have llvm::contains() which would allow you to make this slightly better. Other than that, good find! On Fri, Aug 3, 2018 at 5:49 PM Leonard Mosescu via Phabricator < revi...@reviews.llvm.org> wrote: > lemo created this revision. > lemo added reviewers: zturner, labath, teemperor. > l

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

lemo created this revision. lemo added reviewers: zturner, labath, teemperor. lemo added a project: LLDB. I noticed a suspicious failure: [ RUN ] VMRange.CollectionContains llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure Value of: VMRange::ContainsRange(collection, VMRange