labath added inline comments.
Comment at: unittests/Utility/StreamTest.cpp:38-41
+TEST_F(StreamTest, ChangingByteOrder) {
+ s.SetByteOrder(lldb::eByteOrderPDP);
+ EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder());
+}
probinson wrote:
> teemperor wrote:
> > labat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338488: Added initial unit test for LLDB's Stream
class. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50027?vs=1584
probinson added inline comments.
Comment at: unittests/Utility/StreamTest.cpp:38-41
+TEST_F(StreamTest, ChangingByteOrder) {
+ s.SetByteOrder(lldb::eByteOrderPDP);
+ EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder());
+}
teemperor wrote:
> labath wrote:
> > I've
teemperor added inline comments.
Comment at: unittests/Utility/StreamTest.cpp:38-41
+TEST_F(StreamTest, ChangingByteOrder) {
+ s.SetByteOrder(lldb::eByteOrderPDP);
+ EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder());
+}
labath wrote:
> I've been wondering for a
teemperor updated this revision to Diff 158411.
teemperor marked an inline comment as done.
teemperor added a comment.
- Addressed Pavel's comments.
Will merge once I have time to watch the build bots afterwards.
https://reviews.llvm.org/D50027
Files:
unittests/Utility/CMakeLists.txt
unitt
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is really great. Thank you for doing this. I have some small ideas for
improvement, but I don't think we have to go through another review cycle for
that.
Comment at:
teemperor updated this revision to Diff 158127.
teemperor added a comment.
- Removed MaxHex64 test (which moved to the child revision to be in the same
commit as the related bug).
https://reviews.llvm.org/D50027
Files:
unittests/Utility/CMakeLists.txt
unittests/Utility/StreamTest.cpp
Inde
teemperor created this revision.
Herald added a subscriber: mgorny.
This adds an initial small unit test for LLDB's Stream class, which should at
least cover
most of the functions in the Stream class. StreamString is always in big endian
mode, so that's the only stream byte order path this test c
