This revision was automatically updated to reflect the committed changes.
Closed by commit rL338695: Unit test for Symtab::InitNameIndexes (authored by
stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49909
Files:
lldb/t
sgraenitz added a comment.
Nice. I created a ticket for me internally to turn this into a lit test.
For now I'd merge it once https://reviews.llvm.org/D50071 is done. (But I want
to keep that one open until Jim had a look.)
https://reviews.llvm.org/D49909
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
I agree with Pavel, but I also don't mind having this test in the meantime.
LGTM if you add a FIXME with the direction we want to go.
https://reviews.llvm.org/D49909
__
sgraenitz added a comment.
Sounds very reasonable. I think unit tests are great for development, because
turnaround times are fast and debugging easy. But I am happy to have a look on
how to turn this into a lit test once that's done. Thanks for the remark.
https://reviews.llvm.org/D49909
_
labath added a comment.
I am wondering whether a test like this wouldn't be better of as a lit test
instead of a unit test.
Right now, if you do a `lldb-test symbols foo.o` (and foo.o contains debug
info), we will dump out a very similar index which is built from the
information in the debug_i
sgraenitz created this revision.
sgraenitz added reviewers: labath, jingham, JDevlieghere.
In order to exploit the potential of LLVM's new ItaniumPartialDemangler for
indexing in LLDB, we expect conceptual changes in the implementation of the
InitNameIndexes function. Here is a unit test that ai
