This revision was automatically updated to reflect the committed changes.
Closed by commit rL340560: [cmake] Add option to skip building lldb-server
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49282?vs=155459&
xiaobai added a comment.
In https://reviews.llvm.org/D49282#1164050, @labath wrote:
> In https://reviews.llvm.org/D49282#1163853, @xiaobai wrote:
>
> > In https://reviews.llvm.org/D49282#1163517, @labath wrote:
> >
> > > I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
> >
labath added a comment.
In https://reviews.llvm.org/D49282#1163853, @xiaobai wrote:
> In https://reviews.llvm.org/D49282#1163517, @labath wrote:
>
> > I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
> > different than SKIP_DEBUGSERVER), but while looking at this I got an i
xiaobai added a comment.
In https://reviews.llvm.org/D49282#1163517, @labath wrote:
> I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
> different than SKIP_DEBUGSERVER), but while looking at this I got an idea for
> a possible improvement.
How is it subtly different? Ad
labath added a comment.
I think this is fine (though the meaning of SKIP_LLDB_SERVER is subtly
different than SKIP_DEBUGSERVER), but while looking at this I got an idea for a
possible improvement.
How do you currently convince lldb to use ds2 instead of lldb-server? Do you
just set the LLDB_DE
xiaobai updated this revision to Diff 155459.
xiaobai added a comment.
Update unittest logic.
https://reviews.llvm.org/D49282
Files:
cmake/modules/LLDBConfig.cmake
tools/CMakeLists.txt
unittests/tools/CMakeLists.txt
Index: unittests/tools/CMakeLists.txt
=
xiaobai created this revision.
xiaobai added reviewers: zturner, labath, sas.
Herald added a subscriber: mgorny.
There is currently a way to skip the debugserver build. See how the CMake
variables SKIP_DEBUGSERVER and LLDB_CODESIGN_IDENTITY are used if you're
interested in that.
I'd like the opti
