This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336824: Allow specifying an exit code for the
'quit' command (authored by teemperor, committed by ).
Herald added a subscr
teemperor added a comment.
@clayborg was quite specific about the requested changes (which are all applied
now), so I assume this is good to go.
https://reviews.llvm.org/D48659
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
jingham accepted this revision.
jingham added a comment.
That seems reasonable to me.
https://reviews.llvm.org/D48659
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor updated this revision to Diff 154318.
teemperor added a comment.
- Client now has to explicitly allow the acceptance of exit codes.
- Moved logic to the CommandInterpreter.
- Added more tests.
Thanks for the feedback Jim and Greg, very much appreciated!
https://reviews.llvm.org/D48659
clayborg requested changes to this revision.
clayborg added a comment.
This change seems fine to me. It allows each debugger to have a different exit
status and each debugger can grab one. Seems like this should belong in
lldb_private::CommandInterpreter and lldb::SBCommandInterpreter instead of
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This won't at all do what users expect in cases where the driver program
doesn't cooperate. For instance, when run under Xcode, the lldb process can
have many debuggers running co
teemperor created this revision.
teemperor added a reviewer: davide.
This patch adds the possibility to specify an exit code when calling quit.
We accept any int, even though it depends on the user what happens if the int is
out of the range of what the operating system supports as exit codes.
Fi
