This revision was automatically updated to reflect the committed changes.
Closed by commit rL336287: Fix and simplify lldb.command decorator (authored by
kastiglione, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48658
Files:
lldb/tr
kastiglione updated this revision to Diff 153654.
kastiglione added a comment.
Add tests and make command_name optional
https://reviews.llvm.org/D48658
Files:
packages/Python/lldbsuite/test/functionalities/command_script/TestCommandScript.py
packages/Python/lldbsuite/test/functionalities/c
kastiglione added a comment.
@clayborg I'll dig into how `python-extensions.swig` gets tested, and add
something accordingly.
I have only briefly looked at `cmdtemplate.py`. I can look into adding similar
registration behavior to it. For what it's worth, I prefer functions to classes
for defin
clayborg added a comment.
Can we add a test for this to ensure all functionality that we want? I recently
made changes to the cmdtemplate.py. Maybe we can integrate some more
functionality that auto registers a class somehow?
https://reviews.llvm.org/D48658
_
kastiglione added a subscriber: granata.enrico.
kastiglione added a comment.
Thanks @granata.enrico, sorry for the disruption, I noticed previous comments
after I had submitted this.
https://reviews.llvm.org/D48658
___
lldb-commits mailing list
lld
granata.enrico added a comment.
Thanks for doing this work.
I stopped working on lldb a couple years ago, so I removed myself as a
reviewer. Greg will take good care of you I'm sure.
https://reviews.llvm.org/D48658
___
lldb-commits mailing list
ll
kastiglione updated this revision to Diff 153114.
kastiglione added a comment.
Update a comment
https://reviews.llvm.org/D48658
Files:
scripts/Python/python-extensions.swig
Index: scripts/Python/python-extensions.swig
===
--- s
kastiglione created this revision.
kastiglione added reviewers: clayborg, granata.enrico.
This change fixes one issue with `lldb.command`, and also reduces the
implementation.
The fix: a command function's docstring was not shown when running `help
`. This is because the docstring attached the
