[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

2018-06-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. How is this class different from `lldb_private::CleanUp`? Shouldn't we just delete it and replace all uses with the pre-existing class? Repository: rL LLVM https://reviews.llvm.org/D48337 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

2018-06-19 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL335078: Refactor OnExit utility class in ClangUserExpression (authored by teemperor, committed by ). Herald added a subscr

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

2018-06-19 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. OnExit ensures we call `ResetDeclMap` before this method ends. However, we also have a few manual calls to ResetDeclMap in there that are actually unnecessary because of this (calling the method multiple times has no effect). This patch also moves the class out o