ruiu added inline comments.
Comment at: ELF/Arch/Hexagon.cpp:47
+ for (size_t Bit = 0; Bit != 32; ++Bit) {
+const bool ValBit = (Data >> Off) & 1;
+const bool MaskBit = (Mask >> Bit) & 1;
We normally don't add `const` if the variable's scope is narrow.
sidneym updated this revision to Diff 150013.
sidneym added a comment.
Made the changes Rui suggested.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D47791
Files:
ELF/Arch/Hexagon.cpp
ELF/CMakeLists.txt
ELF/Target.cpp
ELF/Target.h
test/ELF/Inputs/hexagon.s
test/ELF/hexago
ruiu added inline comments.
Comment at: ELF/Arch/Hexagon.cpp:46
+
+ for (size_t Bit = 0; Bit != sizeof(uint32_t) * 8; ++Bit) {
+const bool ValBit = (Data >> Off) & 1;
sizeof(uint32_t) * 8 is always 32.
Comment at: ELF/Arch/Hexagon.cpp:77
+
sidneym created this revision.
sidneym added reviewers: ruiu, shankar.easwaran, kparzysz, bcahoon.
sidneym added a project: lld.
Herald added subscribers: MaskRay, arichardson, mgorny, emaste.
Herald added a reviewer: espindola.
Support B22_PCREL relocation along with a simple test.
I'm also work
