[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-06-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334009: dotest: make inline tests compatible with -f (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47579 Files: lldb/tru

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-06-04 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM > Can you try inserting something like this instead of the > `ApplyDecoratorsToFunction` line and see if your problems go away? > > @wraps(InlineTest._test) > def test_fu

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-05-31 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 149269. labath added a comment. - obliterate using_dsym property - reduce confusion in the MakeInlineTest function (variable "test" used for multiple things) https://reviews.llvm.org/D47579 Files: packages/Python/lldbsuite/test/lldbinline.py Index: pack

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-05-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D47579#1117457, @JDevlieghere wrote: > If I correctly understand this change, this might make it possible to apply > the `add_test_categories` decorator to an inline test. We had issues with > this when introducing the swiftpr category because

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-05-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. If I correctly understand this change, this might make it possible to apply the `add_test_categories` decorator to an inline test. We had issues with this when introducing the swiftpr category because the methods were part of the inline test class. From the descrip

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

2018-05-31 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, aprantl, tberghammer. Herald added a subscriber: eraman. This is split off from https://reviews.llvm.org/D47265 where I needed to be able to invoke every test with -f. That patch is kinda dead now, but this part seems like a good