This revision was automatically updated to reflect the committed changes.
Closed by commit rL333540: [FileSpec] Re-implmenet removeLastPathComponent
(authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47495?vs=14
labath accepted this revision.
labath added inline comments.
Comment at: unittests/Utility/FileSpecTest.cpp:342
+ EXPECT_FALSE(fs_posix_relative.RemoveLastPathComponent());
+ EXPECT_STREQ("foo", fs_posix_relative.GetCString());
+
JDevlieghere wrote:
> labath wr
JDevlieghere added inline comments.
Comment at: unittests/Utility/FileSpecTest.cpp:342
+ EXPECT_FALSE(fs_posix_relative.RemoveLastPathComponent());
+ EXPECT_STREQ("foo", fs_posix_relative.GetCString());
+
labath wrote:
> Is this the behavior you want here? I wa
labath added inline comments.
Comment at: unittests/Utility/FileSpecTest.cpp:342
+ EXPECT_FALSE(fs_posix_relative.RemoveLastPathComponent());
+ EXPECT_STREQ("foo", fs_posix_relative.GetCString());
+
Is this the behavior you want here? I was thinking we could fo
