This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331234: Move the persistent variable counter into Target
(authored by adrian, committed by ).
Herald added a subscriber:
jingham added a comment.
Eh, must have. The page really shouldn't let you overall submit if there are
uncommitted comments, but whatever. Let's see if I did it right this time..
Comment at: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp:668
ConstString ClangUs
aprantl added a comment.
I'm sorry: which inline comment? Did you perhaps forget to hit "Submit"?
https://reviews.llvm.org/D46083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Except for the inline comment, this is okay. If we thought hard we might find
another likely reason why we'd want to use two result prefixes besides a
language that has an error r
aprantl updated this revision to Diff 144628.
aprantl added a comment.
Thread an is_error flag through for plugins that need it.
https://reviews.llvm.org/D46083
Files:
include/lldb/Expression/ExpressionVariable.h
source/Core/ValueObject.cpp
source/Expression/ExpressionVariable.cpp
sourc
aprantl added a comment.
ping.
https://reviews.llvm.org/D46083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl created this revision.
aprantl added a reviewer: jingham.
Move the persistent variable counter into Target so it can be shared across
multiple language plugins.
In a multi-language project it is counterintuitive to have a result
variables reuse numbers just because they are using
