Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

> On Mar 20, 2018, at 4:55 AM, Pavel Labath via lldb-commits > wrote: > > Deleting the test build dir is fairly easy. I can whip up a patch for that, > but I'm not sure if that's the part that is bothering you the most here. > Dealing with the log files is a bot more complicated and there do

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

labath added a subscriber: aprantl. labath added a comment. Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a clear

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a clear consensus on what to do with them. The last discussion abou

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

clayborg added subscribers: labath, clayborg. clayborg added a comment. I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need to

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need to default to true, but if anyone is in that code and would know how to do

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

This revision was automatically updated to reflect the committed changes. Closed by commit rL327703: [dotest] Clean up test folder clean-up (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44526?vs=138579&id=138681#

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! I think this makes sense. Comment at: packages/Python/lldbsuite/test/lldbtest.py:707 +"""Create the test-specific working directory, deleting any previous +

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

labath created this revision. labath added a reviewer: aprantl. Herald added subscribers: eraman, mgorny, ki.stfu, emaste. This patch implements a unified way of cleaning the build folder of each test. This is done by completely removing the build folder before each test, in the respective setUp()