[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

2019-08-09 Thread Francis Ricci via Phabricator via lldb-commits
fjricci abandoned this revision. fjricci added a comment. Didn’t realize I still had open revisions, haven’t worked on lldb in quite some time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44041/new/ https://reviews.llvm.org/D44041 ___ lld

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

2018-03-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Ok, as of r326805 it should be very easy to write a test for this. You can look at the test in that commit for inspiration. Btw, do you happen to know why we have two copies of the section merging code? While working on that patch I noticed an issue that is caused (in pa

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

2018-03-02 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This looks like a perfect case for lldb-test. You will run into a couple of problems which will prevent this from working out of the box. I tried to fix those in https://reviews.llvm

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

2018-03-02 Thread Francis Ricci via Phabricator via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, zturner, labath. Herald added subscribers: JDevlieghere, arichardson, emaste. In order to allow some sections to exist either in split debug-info or in the main binary, don't replace non-empty sections with empty sections. https: