[Lldb-commits] [PATCH] D43577: Fix TestUbsanBasic

2018-02-22 Thread Frederic Riss via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325859: Fix TestUbsanBasic (authored by friss, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43577?vs=135263&id=135590#toc Repository: rL

[Lldb-commits] [PATCH] D43577: Fix TestUbsanBasic

2018-02-21 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. I'd be fine with this version of the patch, or one which uses path.basename to be more stringent. This test is skipped on green dragon because I have not upstreamed the debugger integration for ubs

[Lldb-commits] [PATCH] D43577: Fix TestUbsanBasic

2018-02-21 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. I wonder whether we could use something like >>> import os >>> os.path.basename('/patatino/ino/main.c') 'main.c' to make this slightly more robust against files which end in `main.c` but we don't want to really match, e.g. `blahmain.c`. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D43577: Fix TestUbsanBasic

2018-02-21 Thread Frederic Riss via Phabricator via lldb-commits
friss created this revision. friss added a reviewer: vsk. Herald added a subscriber: kubamracek. Potentially due to the recent testuite refactorings, this test now reports a full absolute path but expect just the filename. For some reason this test is skipped on GreenDragon so we've never seen the