This revision was automatically updated to reflect the committed changes.
Closed by commit rL323197: Fix memory leaks in GoParser (authored by teemperor,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42409?vs=131007&id=131052#toc
Re
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
It looks like all of these parsing functions would benefit from returning
unique_ptr, but that's probably not something we should bother doing now that
we are contemplating removing this code.
teemperor created this revision.
teemperor added reviewers: labath, davide.
The GoParser is leaking memory in the tests due to not freeing allocated nodes
when encountering some parsing errors. With this patch all GoParser tests are
passing with enabled memory sanitizers/ubsan.
https://reviews
